Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed all the println to use log::info | debug #46

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

NoodleSamaChan
Copy link
Contributor

@NoodleSamaChan NoodleSamaChan commented Mar 9, 2024

Hello :)
This is my first PR on the project, please don't hesitate to let me know if anything is wrong with it!

fixes #43

@helio-frota helio-frota self-requested a review March 10, 2024 14:14
@helio-frota
Copy link
Collaborator

hi @NoodleSamaChan thanks for this!

I found nice that you also changed the commented-code-parts 😄 I was expecting this ( because there are some attempts/researches/etc and yeah probably not good to delete commented code at this point) but I forgot to add on the issue description 🤦

In the spirit-of-sync-things ... I'll approve your PR but let's wait a bit ( for others opinion / availability )

2024-03-10_11-36

Since we have other PR with a thing related to logs so that we can see if we need to rebase / we can experiment locally / etc

@helio-frota
Copy link
Collaborator

Added @bobmcwhirter since the other PR was marked as a draft

@helio-frota
Copy link
Collaborator

helio-frota commented Mar 11, 2024

@NoodleSamaChan could you please fix the cargo fmt to make CI happy ? thanks

  • Interestingly vscode is showing nothing to me 👍

2024-03-11_10-45

  • After (control + shift + i) format it fix what CI is complaining

2024-03-11_10-46

@ctron
Copy link
Contributor

ctron commented Mar 11, 2024

Not sure what vscode does. IntelliJ (and friends like Rust Rover) do apply internal formatter by default. You can switch to cargo fmt in the settings.

Ultimately, just run cargo fmt.

@helio-frota helio-frota merged commit e2d6cc8 into trustification:main Mar 11, 2024
1 check passed
@helio-frota
Copy link
Collaborator

@NoodleSamaChan Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change all the println to use log log::info | debug
3 participants