Refactor and enhance version comparison #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to OSV: > ECOSYSTEM: The versions introduced and fixed are arbitrary, > uninterpreted strings specific to the package ecosystem, which does > not conform to SemVer 2.0’s version ordering. > > It is recommended that you provide an explicitly enumerated versions > list when specifying one or more ECOSYSTEM ranges, […] The same is true for the git type. We might consider adding an "exact" scheme in the database. Closes: trustification#900
ctron
force-pushed
the
feature/osv_ver_1
branch
from
51526fc to
0bff50c
Compare
Also, implement generic version comparison.
ctron
changed the title
| return false; | ||
|
|
||
| end | ||
| $$ |
There was a problem hiding this comment.
you could rewrite to be a bit more compact:
create or replace function generic_version_matches(version_p text, range_p version_range)
returns bool
as
$$
begin
return (
(range_p.low_version is not null and range_p.low_inclusive and version_p = range_p.low_version)
or (range_p.high_version is not null and range_p.high_inclusive and version_p = range_p.high_version)
);
end
$$ language plpgsql immutable;
untested, I doubt this would result in such a speed up that it is worth reducing readability
| } | ||
|
|
||
| pub fn get_well_known_prefixes() -> &'static PrefixMatcher { | ||
| WELL_KNOWN_PREFIXES.get_or_init(|| { |
There was a problem hiding this comment.
I wonder (one for the future) if WELL_KNOWN_PREFIXES needs an env var
| pub fn detect(&self, input: &str) -> Option<String> { | ||
| self.prefixes | ||
| .iter() | ||
| .find(|each| input.starts_with(&each.prefix)) |
There was a problem hiding this comment.
have you considered using a find_map here ?
JimFuller-RedHat
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.