Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ai): endpoint improvements. #919

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

chirino
Copy link
Contributor

@chirino chirino commented Oct 12, 2024

  • Move more of the resource info out of the system messages/prefix into the Tools descriptions
  • Disable the product-info tool for now, it’s better to use the sbom-info for similar information.
  • Bump async-openai version
  • switch to new langchain-rust patch branch
  • Add more info to tool response.

* Move more of the resource info out of the system messages/prefix into the
Tools descriptions
* Disable the product-info tool for now, it’s better to use the sbom-info for similar information.
* Bump async-openai version
* switch to new langchain-rust patch branch
* Add more info to tool response.

Signed-off-by: Hiram Chirino <[email protected]>
…iption into the the tooling parameters.

Signed-off-by: Hiram Chirino <[email protected]>
Copy link
Contributor

@ctron ctron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good in general. I noticed the use of some Red Hat specific/preferred terms (RHEL, quarkus). Maybe there's a better way dealing with this.

@helio-frota
Copy link
Collaborator

@chirino that is sorta nit and not required 👍 ...

as you already wrote tests for this feature could you please double check with
cargo clippy -- -W clippy::redundant_clone ? not required but, if you can a void a clone, that means you avoided a memory allocation ... as my noob perspective my only safe/backup/shield thing is the test when I call cargo clippy -- -W clippy::redundant_clone nowadays 👍

@chirino
Copy link
Contributor Author

chirino commented Oct 31, 2024

@chirino that is sorta nit and not required 👍 ...

as you already wrote tests for this feature could you please double check with cargo clippy -- -W clippy::redundant_clone ? not required but, if you can a void a clone, that means you avoided a memory allocation ... as my noob perspective my only safe/backup/shield thing is the test when I call cargo clippy -- -W clippy::redundant_clone nowadays 👍

Then we should add that to cargo xtask precommit and ci bits so that it consistently gets enforced.

@chirino
Copy link
Contributor Author

chirino commented Oct 31, 2024

I think this is good in general. I noticed the use of some Red Hat specific/preferred terms (RHEL, quarkus). Maybe there's a better way dealing with this.

Could do. Just need different example product names.

@chirino chirino added this pull request to the merge queue Oct 31, 2024
Merged via the queue into trustification:main with commit 6f0377a Oct 31, 2024
2 checks passed
@chirino chirino deleted the ai-improvements branch October 31, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants