-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ai): endpoint improvements. #919
Conversation
chirino
commented
Oct 12, 2024
- Move more of the resource info out of the system messages/prefix into the Tools descriptions
- Disable the product-info tool for now, it’s better to use the sbom-info for similar information.
- Bump async-openai version
- switch to new langchain-rust patch branch
- Add more info to tool response.
8e137ac
to
9ea1467
Compare
* Move more of the resource info out of the system messages/prefix into the Tools descriptions * Disable the product-info tool for now, it’s better to use the sbom-info for similar information. * Bump async-openai version * switch to new langchain-rust patch branch * Add more info to tool response. Signed-off-by: Hiram Chirino <[email protected]>
9ea1467
to
c5a2f18
Compare
…iption into the the tooling parameters. Signed-off-by: Hiram Chirino <[email protected]>
9627b3d
to
4da42d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good in general. I noticed the use of some Red Hat specific/preferred terms (RHEL, quarkus). Maybe there's a better way dealing with this.
@chirino that is sorta nit and not required 👍 ... as you already wrote tests for this feature could you please double check with |
Then we should add that to |
Could do. Just need different example product names. |