Introduce a Constraint struct to bridge Query user input and Conditions #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrossley3
force-pushed
the
query-refactor
branch
from
dc7f0ba to
19ac104
Compare
This refactoring clarifies the logic in Filter::parse, hopefully, and opens the door to facilitating access to the parsed components of the Query, useful in the analysis module Signed-off-by: Jim Crossley <[email protected]>
jcrossley3
force-pushed
the
query-refactor
branch
from
19ac104 to
dd221df
Compare
Should make it easier to apply the Query syntax to any context defined by a HashMap of strings. Cleans up the analysis endpoint logic considerably, I think. Signed-off-by: Jim Crossley <[email protected]>
Signed-off-by: Jim Crossley <[email protected]>
Signed-off-by: Jim Crossley <[email protected]>
Signed-off-by: Jim Crossley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #934
This refactoring clarifies the logic in
Filter::parse, hopefully, and opens the door to facilitating access to the parsed components of theQuery, useful in the analysis module