Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version and handle circular deps in analysis graphs #996

Merged

Conversation

JimFuller-RedHat
Copy link
Collaborator

@JimFuller-RedHat JimFuller-RedHat commented Nov 13, 2024

This PR contains a few interconnected changes to analysis graph:

  • add version to node
  • enable filtering with version
  • ensure we handle circular dependencies (ex. etc/test-data/spdx-ubi-examples/v2.json)
  • heavy refactoring of graph routines

Additionally we should no longer extract name from the component pURL - as often a component will not have a pURL ! - so we retrieve from sbom_node.

Note: We can further refactor in retrieve_ fns but left that till whenever we contemplate doing a MRU style forest of graphs.

@JimFuller-RedHat JimFuller-RedHat self-assigned this Nov 13, 2024
@JimFuller-RedHat JimFuller-RedHat changed the title Add cpe, version and handle circular deps Add cpe, version and handle circular deps in analysis graphs Nov 13, 2024
@JimFuller-RedHat JimFuller-RedHat marked this pull request as draft November 13, 2024 08:04
@JimFuller-RedHat JimFuller-RedHat added the Vulnerability Correlation Correlation of vulnerabilities to Packages, SBOMs and Products label Nov 13, 2024
@JimFuller-RedHat JimFuller-RedHat changed the title Add cpe, version and handle circular deps in analysis graphs Add version and handle circular deps in analysis graphs Nov 14, 2024
@JimFuller-RedHat JimFuller-RedHat force-pushed the add-cpe-graph-analysis branch 3 times, most recently from d7e16aa to 63ef8d5 Compare November 14, 2024 11:31
@JimFuller-RedHat JimFuller-RedHat force-pushed the add-cpe-graph-analysis branch 3 times, most recently from 4baa5da to 49d611c Compare November 15, 2024 12:35
@JimFuller-RedHat JimFuller-RedHat marked this pull request as ready for review November 15, 2024 12:43
@JimFuller-RedHat JimFuller-RedHat added this pull request to the merge queue Nov 15, 2024
Merged via the queue into trustification:main with commit 0e3a828 Nov 15, 2024
6 checks passed
@JimFuller-RedHat JimFuller-RedHat deleted the add-cpe-graph-analysis branch November 15, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Vulnerability Correlation Correlation of vulnerabilities to Packages, SBOMs and Products
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants