Add explainer types in payload and return both LIME and SHAP by default #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruivieira
approved these changes
Aug 7, 2024
| @@ -50,6 +55,9 @@ public class ExplainerV1Endpoint { | |||
| @Consumes(MediaType.APPLICATION_JSON) | |||
| public Response explain(@PathParam("modelName") String modelName, KServeV1RequestPayload data) | |||
| throws ExecutionException, InterruptedException { | |||
| // SaliencyResults shapResults = null; | |||
|
@christinaexyou could you change the main README.md too to reflect this change? Can be in a separate PR if you prefer. |
ruivieira
requested changes
Aug 8, 2024
| } else if (explainerType == ExplainerType.SHAP) { | ||
| // SHAP only | ||
| final SaliencyResults results = explainer.explainAsync(prediction, provider).get(); | ||
| response = SaliencyExplanationResponse.fromSaliencyResult(ExplainerType.SHAP, ts(results, ); |
There was a problem hiding this comment.
Typo? This is making the build fail.
ruivieira
requested changes
Aug 8, 2024
| // Handle different explainer types | ||
| if (explainerType == ExplainerType.LIME) { | ||
| // LIME only | ||
| final SaliencyResults results = explainer.explainAsync(prediction, provider).get(); |
There was a problem hiding this comment.
Both requests should be done async and merged only when both are complete.
christinaexyou
force-pushed
the
add-explainers
branch
from
d9368c4
to
177bc85
Compare
ruivieira
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #8 by making the following changes:
src/main/java/org/kie/trustyai/ConfigService.javato return both LIME and SHAPsrc/main/java/org/kie/trustyai/ExplainerV1Endpoint.java&src/main/java/org/kie/trustyai/payloads/SaliencyExplanationResponse.javawith functionality to get both LIME and SHAP or either and adds the explainer type in the infoCurrently, if the explainer type is null then we return both LIME and SHAP but let me know if I should create a new explainer type to be more explicit.