feat(lmeval): Add offline mode as default (#370)

Refer to [RHOAIENG-16200](https://issues.redhat.com/browse/RHOAIENG-16200)
trustyai-explainability · Nov 26, 2024 · 769fa0b · 769fa0b
1 parent 3351631
commit 769fa0b
Show file tree

Hide file tree

Showing 2 changed files with 123 additions and 13 deletions.
diff --git a/controllers/lmes/lmevaljob_controller.go b/controllers/lmes/lmevaljob_controller.go
@@ -713,20 +713,24 @@ func CreatePod(svcOpts *serviceOptions, job *lmesv1alpha1.LMEvalJob, log logr.Lo
 		volumes = append(volumes, outputPVC)
 	}
 
-	// If the job is supposed to run offline, set the appropriate HuggingFace offline flags
-	if job.Spec.IsOffline() {
+	// Enforce offline mode by default
+	offlineHuggingFaceEnvVars := []corev1.EnvVar{
+		{
+			Name:  "HF_DATASETS_OFFLINE",
+			Value: "1",
+		},
+		{
+			Name:  "HF_HUB_OFFLINE",
+			Value: "1",
+		},
+		{
+			Name:  "TRANSFORMERS_OFFLINE",
+			Value: "1",
+		},
+	}
+	envVars = append(envVars, offlineHuggingFaceEnvVars...)
 
-		offlineHuggingFaceEnvVars := []corev1.EnvVar{
-			{
-				Name:  "HF_DATASETS_OFFLINE",
-				Value: "1",
-			},
-			{
-				Name:  "HF_HUB_OFFLINE",
-				Value: "1",
-			},
-		}
-		envVars = append(envVars, offlineHuggingFaceEnvVars...)
+	if job.Spec.IsOffline() {
 
 		// If the job is offline, a storage must be set. PVC is the only supported storage backend at the moment.
 		offlinePVCMount := corev1.VolumeMount{

diff --git a/controllers/lmes/lmevaljob_controller_test.go b/controllers/lmes/lmevaljob_controller_test.go
@@ -116,6 +116,20 @@ func Test_SimplePod(t *testing.T) {
 							MountPath: "/opt/app-root/src/bin",
 						},
 					},
+					Env: []corev1.EnvVar{
+						{
+							Name:  "HF_DATASETS_OFFLINE",
+							Value: "1",
+						},
+						{
+							Name:  "HF_HUB_OFFLINE",
+							Value: "1",
+						},
+						{
+							Name:  "TRANSFORMERS_OFFLINE",
+							Value: "1",
+						},
+					},
 				},
 			},
 			SecurityContext: defaultPodSecurityContext,
@@ -282,6 +296,7 @@ func Test_WithCustomPod(t *testing.T) {
 						RunAsUser:  &runAsUser,
 						RunAsGroup: &runAsGroup,
 					},
+
 					VolumeMounts: []corev1.VolumeMount{
 						{
 							Name:      "shared",
@@ -297,6 +312,20 @@ func Test_WithCustomPod(t *testing.T) {
 							corev1.ResourceCPU: resource.MustParse("1"),
 						},
 					},
+					Env: []corev1.EnvVar{
+						{
+							Name:  "HF_DATASETS_OFFLINE",
+							Value: "1",
+						},
+						{
+							Name:  "HF_HUB_OFFLINE",
+							Value: "1",
+						},
+						{
+							Name:  "TRANSFORMERS_OFFLINE",
+							Value: "1",
+						},
+					},
 				},
 				{
 					Name:    "sidecar1",
@@ -462,6 +491,18 @@ func Test_EnvSecretsPod(t *testing.T) {
 								},
 							},
 						},
+						{
+							Name:  "HF_DATASETS_OFFLINE",
+							Value: "1",
+						},
+						{
+							Name:  "HF_HUB_OFFLINE",
+							Value: "1",
+						},
+						{
+							Name:  "TRANSFORMERS_OFFLINE",
+							Value: "1",
+						},
 					},
 					Command:         generateCmd(svcOpts, job),
 					Args:            generateArgs(svcOpts, job, log),
@@ -591,6 +632,20 @@ func Test_FileSecretsPod(t *testing.T) {
 					Command:         generateCmd(svcOpts, job),
 					Args:            generateArgs(svcOpts, job, log),
 					SecurityContext: defaultSecurityContext,
+					Env: []corev1.EnvVar{
+						{
+							Name:  "HF_DATASETS_OFFLINE",
+							Value: "1",
+						},
+						{
+							Name:  "HF_HUB_OFFLINE",
+							Value: "1",
+						},
+						{
+							Name:  "TRANSFORMERS_OFFLINE",
+							Value: "1",
+						},
+					},
 					VolumeMounts: []corev1.VolumeMount{
 						{
 							Name:      "shared",
@@ -1018,6 +1073,21 @@ func Test_ManagedPVC(t *testing.T) {
 					Command:         generateCmd(svcOpts, job),
 					Args:            generateArgs(svcOpts, job, log),
 					SecurityContext: defaultSecurityContext,
+					Env: []corev1.EnvVar{
+						{
+							Name:  "HF_DATASETS_OFFLINE",
+							Value: "1",
+						},
+						{
+							Name:  "HF_HUB_OFFLINE",
+							Value: "1",
+						},
+						{
+							Name:  "TRANSFORMERS_OFFLINE",
+							Value: "1",
+						},
+					},
+
 					VolumeMounts: []corev1.VolumeMount{
 						{
 							Name:      "shared",
@@ -1134,6 +1204,20 @@ func Test_ExistingPVC(t *testing.T) {
 					Command:         generateCmd(svcOpts, job),
 					Args:            generateArgs(svcOpts, job, log),
 					SecurityContext: defaultSecurityContext,
+					Env: []corev1.EnvVar{
+						{
+							Name:  "HF_DATASETS_OFFLINE",
+							Value: "1",
+						},
+						{
+							Name:  "HF_HUB_OFFLINE",
+							Value: "1",
+						},
+						{
+							Name:  "TRANSFORMERS_OFFLINE",
+							Value: "1",
+						},
+					},
 					VolumeMounts: []corev1.VolumeMount{
 						{
 							Name:      "shared",
@@ -1268,6 +1352,20 @@ func Test_PVCPreference(t *testing.T) {
 							},
 						},
 					},
+					Env: []corev1.EnvVar{
+						{
+							Name:  "HF_DATASETS_OFFLINE",
+							Value: "1",
+						},
+						{
+							Name:  "HF_HUB_OFFLINE",
+							Value: "1",
+						},
+						{
+							Name:  "TRANSFORMERS_OFFLINE",
+							Value: "1",
+						},
+					},
 					VolumeMounts: []corev1.VolumeMount{
 						{
 							Name:      "shared",
@@ -1442,6 +1540,10 @@ func Test_OfflineMode(t *testing.T) {
 							Name:  "HF_HUB_OFFLINE",
 							Value: "1",
 						},
+						{
+							Name:  "TRANSFORMERS_OFFLINE",
+							Value: "1",
+						},
 					},
 					VolumeMounts: []corev1.VolumeMount{
 						{
@@ -1594,6 +1696,10 @@ func Test_OfflineModeWithOutput(t *testing.T) {
 							Name:  "HF_HUB_OFFLINE",
 							Value: "1",
 						},
+						{
+							Name:  "TRANSFORMERS_OFFLINE",
+							Value: "1",
+						},
 					},
 					VolumeMounts: []corev1.VolumeMount{
 						{