Add KServe support #105
Merged
Add KServe support #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update dependencies - Extract function to generate service URL - Remove annotations
ruivieira
requested review from
tteofili and
RobGeada
and removed request for
a team
|
/retest |
danielezonca
approved these changes
Sep 26, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: danielezonca The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test trustyai-service-operator-e2e |
|
New changes are detected. LGTM label has been removed. |
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to KServe inference services (IS) by setting a TrustyAI service as an
InferenceLoggerfor KServe IS.If IS is part of a ModelMesh deployment, the behaviour is the same as previously.
KServe and ModelMesh IS are differentiated by checking the IS's
serving.kserve.io/deploymentMode: ModelMeshannotation.Other changes
v1alpha1tov1beta1