-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lmeval): Enable Kueue Job Manager in LMEval #363
feat(lmeval): Enable Kueue Job Manager in LMEval #363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yhwang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR image build and manifest generation completed successfully! 📦 PR image: 📦 LMES driver image: 📦 LMES job image: 🗂️ CI manifests
|
The only concern is that this will implicitly make trustyai-service-operator depend on Kueue. I guess this may need more discussion. When enabling the Kueue for LMES, one extra update in the
|
@ruivieira: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Thanks @yhwang, this is an important point. I think it's best to close this PR and, for the moment, add the job manager support as an optional overlay on a separate PR. |
Enable LMEval's Job Manager for Kueue support