Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create modal component #82

Merged
merged 3 commits into from
Jan 10, 2019
Merged

Create modal component #82

merged 3 commits into from
Jan 10, 2019

Conversation

jimleeisme
Copy link
Contributor

@jimleeisme jimleeisme commented Dec 6, 2018 •
edited
Loading

WIP on #43

screen shot 2018-12-12 at 8 08 45 pm

EddyIonescu
EddyIonescu approved these changes Dec 13, 2018
View reviewed changes
Copy link
Member

@EddyIonescu EddyIonescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for doing this. Just left a nit about naming. Also, could you post a screenshot of what it looks in the PR? Thanks!

src/components/Modal.jsx Outdated Show resolved Hide resolved
@jimleeisme
Copy link
Contributor Author

I made the modal component just a white box so you can pass it a child component styled however you want.

@akgupta89 akgupta89 merged commit e6d73f3 into master Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EddyIonescu EddyIonescu EddyIonescu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimleeisme @EddyIonescu @akgupta89