Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MDE monitoring configured via advanced features #111

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

jonade
Copy link
Contributor

@jonade jonade commented Jan 6, 2025

Pull Request Template

Description

Please provide the below information so we can validate before merging:

  1. Does the proposed EDR feature align with our definition of telemetry?(definition here)
  2. Could you please provide documentation to support the telemetry you are proposing?(If it is held privately, please reach out to me or @inodee)
  3. If no documentation is available for all the categories you are proposing, could you provide screenshots or sanitized logs?

1: Yes
2: Yes, see below:

3: Not Applicable

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my corrections or additions are accurate
  • I have checked my code and corrected any misspellings

@tsale
Copy link
Owner

tsale commented Jan 6, 2025

This information is not available to the customers through the portal. Please read the eligibility criteria on the website.

If you disagree, please provide evidence with screenshots after running the telemetry generator script available in this repository.

@tsale tsale self-assigned this Jan 6, 2025
@tsale tsale added the waiting for info Further information is requested label Jan 6, 2025
@jonade
Copy link
Contributor Author

jonade commented Jan 13, 2025

Yes, Kernel load events show up in the Timeline view:

image

Network Sockets however doesn't appear, so I guess it should be removed

@jonade
Copy link
Contributor Author

jonade commented Jan 23, 2025

@tsale Retested it again today and these show up.

The NetworkRawSocket test shows up in the Timeline view for the device:

image

image

As well as the NetworkListen test:

image

image

@jonade
Copy link
Contributor Author

jonade commented Jan 23, 2025

There was also an issue with the testing script and dependencies on my Debian machine which meant the Cron test had previously been failing. Once I resolved that, the telemetry shows up in the Timeline view:

image

I'll push an update to also mark Service Creation as a Yes.

@tsale Should I also revert back the change for the Network Socket checks back to their original state? (Enabled via Telemetry)

@tsale
Copy link
Owner

tsale commented Jan 23, 2025

Can you please show us a screenshot from the hunting page to make sure those attributes are searchable and can show the whole event?

@jonade
Copy link
Contributor Author

jonade commented Jan 23, 2025

@tsale NetworkListen is in the DeviceNetworkEvents table:
image
image

NetworkRawSocket and Cron I can't see which table it would be.

@tsale
Copy link
Owner

tsale commented Jan 23, 2025

Thank you @jonade! We do not keep track of NetworkRawSocket anymore. I changed the service creation to Partially with the explanation that it is not searchable and it's only available in the timeline platform.

…tion for partial availability in value explanations.
@tsale tsale merged commit ae1c6c1 into tsale:main Jan 23, 2025
@jonade
Copy link
Contributor Author

jonade commented Jan 23, 2025

Thanks @tsale. What about Network Listen? That one I provided the evidence for, but it never got updated in the result table.

@tsale
Copy link
Owner

tsale commented Jan 23, 2025

I might have missed it. Will make the change directly shortly.

tsale added a commit that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for info Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants