Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gerber now outputs drill file #6

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

ShiboSoftwareDev
Copy link
Contributor

@seveibar It was confusing to debug gerber using this repo since the main repo outputs a drill file with gerber and this doesn't

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea i wasn't sure if we should mix gerber and excellon drill because they're technically different formats, but i think it's probably OK for now since they're so similar

@seveibar seveibar merged commit 17bf1fa into tscircuit:main Sep 9, 2024
2 checks passed
@ShiboSoftwareDev
Copy link
Contributor Author

ShiboSoftwareDev commented Sep 9, 2024

yea i wasn't sure if we should mix gerber and excellon drill because they're technically different formats, but i think it's probably OK for now since they're so similar

@seveibar

  • doesn't pcb manufacturers need excellon drill with gerber? If so then it makes sense to test them together
  • also have you thought of making builder/core use this repo in production? easier for debugging, development and you would be able to test it with other repos like footprinter. Right now I don't know about core but builder uses duplicate code with this one

@seveibar
Copy link
Contributor

seveibar commented Sep 9, 2024

@ShiboSoftwareDev yes the intent of this module is for BOTH @tscircuit/core and @tscircuit/builder to use them, we just need to refactor those repos to use this module. Currently @tscircuit/core doesn't support exports at all.

Note that for @tscircuit/core this repo should be an optional dependency, so it must be dynamically imported (circuit-to-svg is used this way inside of core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants