add square pcb plated hole

[techmannih]

related to tscircuit/core#429

[techmannih]

@imrishabh18 please review this PR

[seveibar]

@techmannih i think it's ambiguous if the hole is square or the plating is square, circuit json should be unambiguous so we need to clarify

I'm not sure what @imrishabh18 was thinking about here, but it seems like we need to describe "square plating with circular hole"? Is that right @imrishabh18 ?

I would recommend picking a nice name for "shape", then also adding "hole_shape" and "plating_shape" pad_shape for clarity (pad is a better word than plating here)

[seveibar]

Square holes are uncommon, so I think rishabh was likely talking about a circular hole with square plating as shown below

[imrishabh18]

Yeah, my fault I should have added the picture in the issue. I was talking about the square plate and circular hole

[seveibar]

this is the first time that we have an ambiguous situation w/ the shape property, I'd recommend the shape name to be shape: "circular_hole_with_square_pad" and the clarifying hole_shape: "circle" and pad_shape: "square" to be added

it sounds like overkill but in it will be worth it when the specification is unambiguous!

[seveibar]

reread my comments carefully, you didn't address them (not even close- you missed almost all of them?)

[techmannih]

Oh my bad, sorry @seveibar , please review now

[seveibar]

a square always has the same width/height, so it doesn't make sense to define a width and height unless we're doing a redudant definition, but we typically don't do this for rects (we usually just call it a rect and give it a width and height)

[techmannih]

@seveibar done