Nonexistent Symbol Handling, Bad Symbol Port Match Handling #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
seveibar
commented
Nov 10, 2024
seveibar
commented
- add nonexistent symbol handling
- fix snapshot
- add error message when symbol ports don't align
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seveibar
commented
Nov 10, 2024
| } | ||
| }), | ||
| ), | ||
| ).toMatchSvgSnapshot(import.meta.path) |
There was a problem hiding this comment.
the ports fail to match for box_resistorvert because core doesn't properly computed rotated symbols
seveibar
force-pushed
the
nonexistent-symbol-handling
branch
from
dce7a15 to
8ed970a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.