add 4pin crystal #440
Closed
add 4pin crystal #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imrishabh18
reviewed
Dec 20, 2024
There was a problem hiding this comment.
I think probably we should use the <Crystal /> component already present, and not introduce a new component just for when we are having 4pins?
cc: @seveibar
There was a problem hiding this comment.
is it needed to introduce a new component. right?
There was a problem hiding this comment.
No modify the existing Crystal to support the pinVariant prop
|
@techmannih Please address the comments before asking for the review's |
|
@imrishabh18 I have resolved these conversation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4pinCrystal
/claim #389