Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add A type #136

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

add A type #136

wants to merge 6 commits into from

Conversation

techmannih
Copy link

@techmannih techmannih commented Dec 26, 2024 •
edited
Loading

fix #124
/claim #124

@techmannih techmannih marked this pull request as draft December 26, 2024 08:14
@algora-pbc algora-pbc bot mentioned this pull request Dec 26, 2024
Open
@techmannih techmannih marked this pull request as ready for review December 26, 2024 17:15
@techmannih techmannih marked this pull request as draft December 26, 2024 17:15
@techmannih techmannih marked this pull request as ready for review December 31, 2024 20:13
@techmannih
Copy link
Author

@seveibar review this PR once

Anshgrover23
Anshgrover23 requested changes Jan 1, 2025
View reviewed changes
Copy link

@Anshgrover23 Anshgrover23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@techmannih your checks are failing !!
image

@techmannih
Copy link
Author

@Anshgrover23 please give suggestion, I have implemented A type please suggest where its failure, I need suggestion for this

@Anshgrover23
Copy link

@techmannih the test you have made kindly check it is failing i think some snapshot is wrong or your implementation. Kindly try to run tests locally first and sees the issue, if u need help after that bro msz me on discord.

@techmannih
Copy link
Author

@techmannih the test you have made kindly check it is failing i think some snapshot is wrong or your implementation. Kindly try to run tests locally first and sees the issue, if u need help after that bro msz me on discord.

sure @Anshgrover23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anshgrover23 Anshgrover23 Anshgrover23 requested changes

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C388629] Failed to import from JLCPCB
2 participants
@techmannih @Anshgrover23