fixed filepath bug #212
fixed filepath bug #212
Conversation
|
We can increase the timeout for the test inside the workflow (not a big deal) do you want to make that edit to see if the tests pass? I didn't understand your other issue, the diff is a bit hard to read because of a formatting issue, maybe you could run |
| .stderr(debug.enabled ? "inheritPiped" : "piped") | ||
| .stdout(debug.enabled ? "inheritPiped" : "piped") | ||
| } catch (e) { | ||
| console.log(e) |
There was a problem hiding this comment.
hmm we should probably revert this part because it allows continuing after errors
| .stderr(debug.enabled ? "inheritPiped" : "piped") | ||
| .stdout(debug.enabled ? "inheritPiped" : "piped") | ||
| } catch (e) { | ||
| console.log(e) |
| .stdout(debug.enabled ? "inheritPiped" : "piped") | ||
| .stderr(debug.enabled ? "inheritPiped" : "piped") | ||
| .noThrow() | ||
| try { |
There was a problem hiding this comment.
do we need this big try catch here?
There was a problem hiding this comment.
I forgot to remove these
cli/lib/soupify/soupify-with-core.ts
Outdated
|
|
||
| writeFileSync("${tmpOutputPath}", JSON.stringify(project.getCircuitJson())) | ||
| `.trim(), | ||
| import React from "react" |
There was a problem hiding this comment.
it's actually correct here to not have indentation, the output file is going to have a lot of indentation if we add indentation here
There was a problem hiding this comment.
I'll reverse this change
cli/lib/export-fns/export-gerbers.ts
Outdated
| @@ -29,6 +29,7 @@ export const exportGerbersToFile = async ( | |||
| }, | |||
| ctx, | |||
| ) | |||
| console.log(soup, "soup") | |||
There was a problem hiding this comment.
| console.log(soup, "soup") |
cli/lib/export-fns/export-gerbers.ts
Outdated
| @@ -91,7 +92,7 @@ export const exportGerbersToZipBuffer = async ( | |||
| ) => { | |||
| const tempDir = Path.join(".tscircuit", "tmp-gerber-zip") | |||
| fs.mkdirSync(tempDir, { recursive: true }) | |||
|
|
|||
| console.log("step two") | |||
There was a problem hiding this comment.
| console.log("step two") |
cli/lib/export-fns/export-gerbers.ts
Outdated
| @@ -100,6 +101,7 @@ export const exportGerbersToZipBuffer = async ( | |||
| }, | |||
| ctx, | |||
| ) | |||
| console.log("step last") | |||
There was a problem hiding this comment.
| console.log("step last") |
|
@seveibar I used to review my own code I don't why I stopped doing that, sorry for that |
|
@ShiboSoftwareDev all good, we should enable a lint rule for console log lines anyway so that its not easy to leave them in- i think biome has a setting |
there are two new issues: