Skip to content
This repository has been archived by the owner on Aug 26, 2024. It is now read-only.

fixed mobylette load error in Rails5.0.0.rc1 #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed mobylette load error in Rails5.0.0.rc1 #53

wants to merge 2 commits into from

Conversation

wenweih
Copy link

@wenweih wenweih commented May 13, 2016

The error message is:

`rescue in block (2 levels) in require': There was an error while trying to load the gem 'mobylette'. (Bundler::GemRequireError)
Gem Load Error is: uninitialized constant ActionView::FileSystemResolver

need to require specify rails module:require 'action_view/template/resolver'

16-5-17 update:

before_filter is deprecated and will be removed in Rails 5.1. Use before_action instead

@garlou
Copy link

garlou commented Jun 14, 2016

What is wrong with this PR?

@verymilan
Copy link

Why is this still open? o.O

elDub added a commit to MachineTools/mobylette that referenced this pull request Jun 8, 2017
Duplicate changes on this pull request to continue usage of mobylette
until the full responsive UI is complete.
@ikuwow
Copy link

ikuwow commented Mar 15, 2018

https://github.com/tscolari/mobylette/pull/53/files#diff-9f99796b5fe9f9971c8e8df2a2ce7414R36
it removes annoying deprection warning: DEPRECATION WARNING: before_filter is deprecated and will be removed in Rails 5.1. Use before_action instead. (called from block in <module:RespondToMobileRequests> at ... in rails 5.0.3

Please merge it!

Copy link

@bolef2k bolef2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been implemented in the master? I get the error still and it doesn't work under Rails 5.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants