Independent Module - swss code to support port SI configuration per speed #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junchao-Mellanox
suggested changes
Sep 22, 2023
|
I did not finish the review, too many format change. Please fix the format issue first and then I will review rest of them. |
tshalvi
force-pushed
the
code_for_CR
branch
from
01f790c to
2730424
Compare
tshalvi
force-pushed
the
code_for_CR
branch
from
2730424 to
2500615
Compare
Junchao-Mellanox
suggested changes
Sep 27, 2023
orchagent/portsorch.cpp
Outdated
| SWSS_LOG_INFO("Creating serdes for port 0x%" PRIx64, port_id); | ||
| SWSS_LOG_DEBUG("Creating serdes for port 0x%" PRIx64 " with the following SI parameters:", port_id); | ||
|
|
||
| for (const auto &entry : serdes_attr) |
There was a problem hiding this comment.
Do you want to keep this for loop for production code? As I can see it is only for debug purpose and we can find such information from log file /var/log/swss/swss.rec. I would suggest to remove them.
Junchao-Mellanox
approved these changes
Oct 12, 2023
|
@tshalvi is this PR still be worked on? I see its in DRAFT mode? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I added six new SI parameters to the relevant locations in SWSS and introduced a log to display the SI values sent by SONiC to SAI.
Why I did it
I made these additions to support the new SI parameters recently added to APP_DB.
How I verified it
I verified it using the existing unit tests, and I will be adding new unit tests in the near future.
Details if related
HLD: sonic-net/SONiC#1455