Translate enum string name to underlying enum type

[charliettaylor]

Drafting this for now since it needs more work, but I think I have the gist of it!

• Add field to ColumnInfo to store the enum that will translate the string
• Change tests to Strict mode because enum can only be specified in Strict mode
• Update EmployeeObj to have an enum for testing
  • need to add more tests
• Only implemented for LinqExecutor, need to make sure it works for all other ones as well

[tspence]

Thanks for this PR! I’m traveling right now but will return on Sept 9 and can review and merge.

[tspence]

I should mention that searchlight used to be really good with enums - I was a heavy user of enums back in 2015; but I gradually started phasing them out in most of my APIs which is why the test coverage probably isn’t as good anymore. Thanks for working on this!

[charliettaylor]

Updates

• Update testing for all supported DB types, now support automatic enum translation
  • Mongo is a bit weird if you don't use int, other sources let you use tinyint/byte or other types of ints
• Update a couple files to use file scoped namespaces
• Formatting and cleanup
• Not sure why GitHub workflow isn't passing, all the checks pass on my local Docker containers
  • Looks like something from this error The format of the analysis property sonar.login= is invalid, SonarCloud config might need updating?
  • Resolves SearchlightField EnumType doesn't do anything #136

[tspence]

I'm back from travels and am looking at this PR.

[tspence]

Darnit, it looks like this has some conflicts with my work on autocomplete. Let me try to merge

[tspence]

@charliettaylor this PR now passes all tests locally - I'm not sure exactly why the github action is failing. It seems to be not allowing you to view the SonarCloud token on the repository since the PR comes from your repo. Regardless, I'm happy to merge this - are my changes OK to you?

[tspence]

Only concern is that enumType seems duplicative. I remember I had that in my code originally specifically for cases where the underlying value was an enum but it was presented in the API as a string or integer.

[charliettaylor]

Only concern is that enumType seems duplicative. I remember I had that in my code originally specifically for cases where the underlying value was an enum but it was presented in the API as a string or integer.

Yeah I tried to avoid having another enum type field, but the way that the DataSource parses it makes it simpler to pass it via ColumnInfo. Your changes look fine to me! I'll merge it in a bit