fix bug with same key in one context #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexMost
reviewed
Dec 12, 2023
src/utils.ts
Outdated
| @@ -175,6 +175,11 @@ export function transformCompactObj(compactObj: TTagCompactTranslations) { | |||
| const msgid = msgids[j]; | |||
| const translations = compactObj.contexts[ctx][msgid]; | |||
| const [newMsgid, newTranslations] = transformCompactTranslate(msgid, translations); | |||
| if (process.env.NODE_ENV !== 'production' && newContext[newMsgid]) { | |||
| throw new Error( | |||
| `Wrong data! Context "${ctx}" already have key "${newMsgid}", You should change key "${msgid}" or use different context`, | |||
There was a problem hiding this comment.
Maybe we can improve the error message, lets rephrase that to something like:
const [newMsgid, newTranslations] = transformCompactTranslate(msgid, translations);
const existingMsgid = newContext[newMsgid];
...
throw new Error(`Duplicate msgid (${msgid} and ${existingMsgid} will be interpreted as the same key) this potentially can lead to translation loss. Consider using context for one of those msgid`s. See the context doc here - https://ttag.js.org/docs/context.html`)
stoyanovk
force-pushed
the
fix_for_bug_with_same_key
branch
2 times, most recently
from
e810cc4 to
cf34732
Compare
stoyanovk
force-pushed
the
fix_for_bug_with_same_key
branch
from
cf34732 to
c2c8eff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug that was in issue #209