Partial refactored Issue 54 and resulting issues #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # de.variantsync.core/src/main/java/de/variantsync/core/ast/AST.java # de.variantsync.core/src/main/java/de/variantsync/core/ast/JsonParserASTwithLineGrammar.java
…nlder, DefaultMarkerHandler, SourceFile, CodeMapping, CodeMappingFormat
pmbittner
reviewed
Apr 26, 2021
There was a problem hiding this comment.
This is not pretty but it's ok as the intermediate state. However, it would be very very helpful if you could at some last documentation. There are many parts that you heavily refactored in the eclipse plugin. Please add JavaDoc to those methods or class explaining what you think this class/method does (which enabled you to apply your refactoring).
| return Collections.emptyList(); | ||
| } | ||
| // return Collections.unmodifiableList(subtrees); | ||
| return subtrees; |
There was a problem hiding this comment.
Why is this change necessary? Please add a comment.
| public static String getString() { | ||
|
|
||
| return "da srtring"; | ||
| } |
| //List<IVariantSyncMarker> markers = ASTLineGrammarProcessor.getMarkers(root); | ||
|
|
||
|
|
||
| assertTrue(true); |
| // assertEquals(astString, importedString); | ||
| // | ||
| // // delete created file | ||
| // Files.delete(examplePath); | ||
| } |
There was a problem hiding this comment.
Why is all of this commented out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #54
closes #55
closes #58
closes #61
closes #69