-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Suggestion] add a variables file, allow modifying the variables used in the scss files #51
Comments
Totally in favor of this approach |
I would like to do this in #67 |
tagliala
added a commit
to tagliala/select2-bootstrap4-theme
that referenced
this issue
Mar 13, 2021
tagliala
added a commit
to tagliala/select2-bootstrap4-theme
that referenced
this issue
Mar 14, 2021
tagliala
added a commit
to tagliala/select2-bootstrap4-theme
that referenced
this issue
Mar 14, 2021
tagliala
added a commit
to tagliala/select2-bootstrap4-theme
that referenced
this issue
Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
im not a fan of the forcing of using secondary for many of the label colours etc. wouldnt it be better if you included a
_variables.scss
file similar to how bootstrap does it with !default? that way we can override the defaults with say$select2-theme-bootstrap4-secondary: $gray;
should be as easy as finding $ and then just prefixing them with a prefix and setting up a _variables.scss file
The text was updated successfully, but these errors were encountered: