[fix] Fixing the namespacing for the sonar plugin #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespacing for sonar plugin
While using the
gazebo_ros_sonar
plugin in a drone URDF model and spawning this type of drone several times in my.world
with different robot namespaces, I encountered that type of error, since the same namespacing is used for all sonars on all drones:[ERROR] [1598280399.141939871, 74.990000000]: Tried to advertise a service that is already advertised in this node [/sonar_front_center_015/range/set_parameters]
I offer here a solution which is highly inspired by the methods
GetModelName
andGetRobotNamespace
from gazebo_ros_utils.h. Those two methods are used in thegazebo_ros_camera
plugin and allow several robots from the same model to have their own sensors with their own topics.