Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Module Update 1: Tests + Minor Features #137

Merged

Conversation

tristandijkstra
Copy link
Contributor

@tristandijkstra tristandijkstra commented Feb 15, 2024

This pull requests introduces the first significant update to the data module (Horizons, MPC, SBDB). The following changes have been made:

Features

  • Implementation of the JPL Horizons Ephemeris API
  • New feature to retrieve interpolated observation data (RA/DEC) using the JPL Horizons Ephemeris API
  • A wrapper has been created that allows for the generation of JPL Horizons Tabulated Ephemeris settings through tudatpy.numerical_simulation.environment_setup.ephemeris
  • A wrapper has been created that allows for the generation of central_sbdb gravity model settings using SBDB in tudatpy.numerical_simulation.environment_setup.gravity_field
  • another central_sbdb_density model setting allows for gravity field creation based on the sbdb diameter and a user-inputted density.
  • Additional paramaters for the SBDB query such as gravitational parameter, diameter and orbit class.
  • Exposed add_gravity_field_model in tudatpy.numerical_simulation.environment_setup.
  • added option to add central_sbdb to bodies when running .to_tudat() in BatchMPC.

Tests

  • Automated test to cover user input for BatchMPC
  • Automated test to cover user input for JPL Horizons
  • Automated test comparing JPL Cartesian to SPICE ephemeris
  • Automated test comparing JPL interpolated RA/DEC data to BatchMPC
  • Automated test comparing BatchMPC ObservationCollection retrieved using to_tudat() to the original observation data

Automated tests have a 87% coverage for Horizons and 88% coverage of BatchMPC.

@tristandijkstra
Copy link
Contributor Author

@DominicDirkx when merged, please add the following two files to the testset:

  • tests\test_data_mpc.py
  • tests\test_data_horizons.py

@tristandijkstra
Copy link
Contributor Author

This update is complemented by a small addition in the first MPC example: tudat-team/tudatpy-examples#41

@tristandijkstra tristandijkstra marked this pull request as ready for review February 21, 2024 15:32
@tristandijkstra tristandijkstra changed the title Data Module Update 1 Data Module Update 1: Tests + Minor Features Feb 21, 2024
@DominicDirkx DominicDirkx merged commit 566306b into tudat-team:develop Mar 5, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants