[feedback wanted] refactor: Limit BuildSettings usage to only String and [String] values
#139
+74
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waltflanagan
requested review from
pepicrft,
ajkolean,
fortmarek and
kwridan
waltflanagan
force-pushed
the
waltflanagan/RefineBuildSettings
branch
from
869b66d to
e660b0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In working on tuist/XcodeProj#903 i've found that build settings defined in project files are always deserialized and
Stringand[String]types. Other types likeBoolorDictionaryare not representable within build settings. Even for boolean settings, Xcode encodes and decodes the strings"YES""NO".Secondarily, there are some things within
BuildSettings.swiftthat are specific to tuist behavior like default build settings for mergable libraries, and scheme generation. I'm not sure how these are intended to be used but as they are not part of a standardxcodeprojI don't believe we want to be attempting to read tuist value that are put into build settings.Opening this PR to start a conversation on the path forward related to these two topics.