Add copy_from_namespace parameter + test #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morgan Gallant <[email protected]>
Signed-off-by: Morgan Gallant <[email protected]>
Arash-11
reviewed
Feb 20, 2025
turbopuffer/namespace.py
Outdated
| @@ -185,6 +185,19 @@ def update_schema(self, schema_updates: NamespaceSchema): | |||
| response = self.backend.make_api_request('namespaces', self.name, 'schema', method='POST', payload=request_payload) | |||
| return parse_namespace_schema(response["content"]) | |||
|
|
|||
| def copy_from_namespace(self, other_namespace: str): | |||
There was a problem hiding this comment.
this is more of a personal preference thing: from_namespace/source_namespace/namespace_name would look a bit nicer i think? in case one uses keyword arguments:
ns2.copy_from_namespace(namespace_name=ns1_name)
vs
ns2.copy_from_namespace(other_namespace=ns1_name)
There was a problem hiding this comment.
Went with source_namespace, much cleaner
| @@ -1,6 +1,6 @@ | |||
| [tool.poetry] | |||
| name = "turbopuffer" | |||
| version = "0.1.28" | |||
| version = "0.1.29" | |||
There was a problem hiding this comment.
also need to update version.py
Signed-off-by: Morgan Gallant <[email protected]>
Arash-11
approved these changes
Feb 20, 2025
|
The idea is that at some point you can use copy_from_namespace to do schema migrations FWIW |
philipk19238
pushed a commit
to sweetspot-ai/turbopuffer-python
that referenced
this pull request
Mar 6, 2025
* copy from namespace Signed-off-by: Morgan Gallant <[email protected]> * fix namespace names in tests Signed-off-by: Morgan Gallant <[email protected]> * address pr comments Signed-off-by: Morgan Gallant <[email protected]> --------- Signed-off-by: Morgan Gallant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original iteration I edited the upsert function, but since copy_from_namespace doesn't accept documents or schema changes, it doesn't really make sense to have it be the same function. I think it's better to have it be its own function so that the invalid input is inexpressible