clippy
13 errors
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 13 |
Warning | 0 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.74.1 (a28077b28 2023-12-04)
- cargo 1.74.1 (ecb9851af 2023-10-18)
- clippy 0.1.74 (a28077b 2023-12-04)
Annotations
Check failure on line 59 in src/hal/serial.rs
github-actions / clippy
useless conversion to the same type: `std::vec::Vec<hal::serial::Handler>`
error: useless conversion to the same type: `std::vec::Vec<hal::serial::Handler>`
--> src/hal/serial.rs:59:23
|
59 | handlers: handlers.into(),
| ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `handlers`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
Check failure on line 185 in src/hal/serial.rs
github-actions / clippy
methods `get_state` and `open_channel` are never used
error: methods `get_state` and `open_channel` are never used
--> src/hal/serial.rs:185:12
|
164 | impl Handler {
| ------------ methods in this implementation
...
185 | pub fn get_state(&self) -> HandlerState {
| ^^^^^^^^^
...
193 | pub fn open_channel(&self) -> Result<SerialChannel, SerialError> {
| ^^^^^^^^^^^^
Check failure on line 146 in src/hal/serial.rs
github-actions / clippy
enum `HandlerState` is never used
error: enum `HandlerState` is never used
--> src/hal/serial.rs:146:6
|
146 | enum HandlerState {
| ^^^^^^^^^^^^
Check failure on line 109 in src/hal/serial.rs
github-actions / clippy
field `inner` is never read
error: field `inner` is never read
--> src/hal/serial.rs:109:5
|
108 | pub struct SerialChannel {
| ------------- field in this struct
109 | inner: (broadcast::Receiver<BytesMut>, mpsc::Sender<BytesMut>),
| ^^^^^
Check failure on line 75 in src/hal/serial.rs
github-actions / clippy
methods `open_channel` and `get_state_handlers` are never used
error: methods `open_channel` and `get_state_handlers` are never used
--> src/hal/serial.rs:75:18
|
39 | impl SerialConnections {
| ---------------------- methods in this implementation
...
75 | pub async fn open_channel(
| ^^^^^^^^^^^^
...
102 | pub fn get_state_handlers(&self) -> Vec<HandlerState> {
| ^^^^^^^^^^^^^^^^^^
|
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
Check failure on line 102 in src/hal/serial.rs
github-actions / clippy
type `hal::serial::HandlerState` is more private than the item `hal::serial::SerialConnections::get_state_handlers`
error: type `hal::serial::HandlerState` is more private than the item `hal::serial::SerialConnections::get_state_handlers`
--> src/hal/serial.rs:102:5
|
102 | pub fn get_state_handlers(&self) -> Vec<HandlerState> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `hal::serial::SerialConnections::get_state_handlers` is reachable at visibility `pub(crate)`
|
note: but type `hal::serial::HandlerState` is only usable at visibility `pub(self)`
--> src/hal/serial.rs:146:1
|
146 | enum HandlerState {
| ^^^^^^^^^^^^^^^^^
= note: `-D private-interfaces` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(private_interfaces)]`
Check failure on line 140 in src/hal/serial.rs
github-actions / clippy
unused variable: `cx`
error: unused variable: `cx`
--> src/hal/serial.rs:140:9
|
140 | cx: &mut std::task::Context<'_>,
| ^^ help: if this is intentional, prefix it with an underscore: `_cx`
Check failure on line 133 in src/hal/serial.rs
github-actions / clippy
unused variable: `cx`
error: unused variable: `cx`
--> src/hal/serial.rs:133:9
|
133 | cx: &mut std::task::Context<'_>,
| ^^ help: if this is intentional, prefix it with an underscore: `_cx`
Check failure on line 126 in src/hal/serial.rs
github-actions / clippy
unused variable: `buf`
error: unused variable: `buf`
--> src/hal/serial.rs:126:9
|
126 | buf: &[u8],
| ^^^ help: if this is intentional, prefix it with an underscore: `_buf`
Check failure on line 125 in src/hal/serial.rs
github-actions / clippy
unused variable: `cx`
error: unused variable: `cx`
--> src/hal/serial.rs:125:9
|
125 | cx: &mut std::task::Context<'_>,
| ^^ help: if this is intentional, prefix it with an underscore: `_cx`
Check failure on line 116 in src/hal/serial.rs
github-actions / clippy
unused variable: `buf`
error: unused variable: `buf`
--> src/hal/serial.rs:116:9
|
116 | buf: &mut tokio::io::ReadBuf<'_>,
| ^^^ help: if this is intentional, prefix it with an underscore: `_buf`
Check failure on line 115 in src/hal/serial.rs
github-actions / clippy
unused variable: `cx`
error: unused variable: `cx`
--> src/hal/serial.rs:115:9
|
115 | cx: &mut std::task::Context<'_>,
| ^^ help: if this is intentional, prefix it with an underscore: `_cx`
|
= note: `-D unused-variables` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_variables)]`
Check failure on line 147 in src/hal/serial.rs
github-actions / clippy
variant `initialized` should have an upper camel case name
error: variant `initialized` should have an upper camel case name
--> src/hal/serial.rs:147:5
|
147 | initialized,
| ^^^^^^^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Initialized`
|
= note: `-D non-camel-case-types` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(non_camel_case_types)]`