Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsql: use hyper for offline writes #1829

Merged
merged 4 commits into from
Nov 20, 2024
Merged

libsql: use hyper for offline writes #1829

merged 4 commits into from
Nov 20, 2024

Conversation

LucioFranco
Copy link
Contributor

This PR adds 3 new commits related to integrating hyper into offline writes. This also includes tls support.

Tested this against a platform server:

❯ cargo run --example offline_writes
   Compiling libsql v0.6.0 (/home/lucio/code/libsql/libsql)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.21s
     Running `target/debug/examples/offline_writes`
Please write your entry to the guestbook:
hello
You entered: hello

Guest book entries:
  cargo run --example offline_writeshello

  hello

  hello

  hello

Syncing database to remote...
Done!

@LucioFranco
libsql: Switch to hyper for local offline sync-switch-hyper
4fc36f3 
This commit switches our usage of reqwest to hyper. In the future, this
will allow us to pass in configuration for the connector to support both
custom TLS implementations (aka using the system tls impl over rustls)
and connecting to the sqld network simulation for future testing. This
also removes the extra dependency on reqwest which is not needed since
we already pull in the dependencies needed to implement the new
protocol for local offline writes.
@LucioFranco
libsql: re-use hyper client for offline sync
cf9f513
@LucioFranco
libsql: add tls hyper support for offline writes
9c4f424
haaawk
haaawk approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@haaawk haaawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably squash the last two commits but appart from that I'm really starting to enjoy reviewing your PRs!

@LucioFranco LucioFranco added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 49e6393 Nov 20, 2024
18 checks passed
@LucioFranco LucioFranco deleted the lucio/local-offline-hyperv2 branch November 20, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haaawk haaawk haaawk approved these changes

@penberg penberg Awaiting requested review from penberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucioFranco @haaawk