Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SELECT ABS(-9223372036854775808) causes limbo to panic. #818

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Fix SELECT ABS(-9223372036854775808) causes limbo to panic. #818

merged 2 commits into from
Jan 30, 2025
+16 −10

Conversation

krishvishal
Copy link
Contributor

Now we return RuntimeError. Matches SQLite behavior.

SQLite:

sqlite> SELECT ABS(-9223372036854775808);
Runtime error: integer overflow

Limbo after this fix:

limbo> SELECT ABS(-9223372036854775808);
Runtime error: integer overflow

Closes #815

levydsa
levydsa reviewed Jan 29, 2025
View reviewed changes
core/vdbe/mod.rs Outdated Show resolved Hide resolved
penberg
penberg reviewed Jan 29, 2025
View reviewed changes
core/error.rs Outdated Show resolved Hide resolved
@penberg penberg merged commit a2ac313 into tursodatabase:main Jan 30, 2025
38 of 39 checks passed
@krishvishal krishvishal deleted the fix-abs-overflow-panic branch January 31, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levydsa levydsa levydsa left review comments

@penberg penberg penberg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SELECT ABS(-9223372036854775808) causes limbo to panic
3 participants
@krishvishal @penberg @levydsa