Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagecount #819

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+227 −172
Open

Pagecount #819

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5419396
start page count at 0
glommer Jan 29, 2025
f0660a9
add compat statement about CreateBTree opcode
glommer Jan 29, 2025
e338b5e
implement the pragma page_count
glommer Jan 29, 2025
2932972
move database_size back to one
glommer Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/storage/sqlite3_ondisk.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ impl Default for DatabaseHeader {
min_embed_frac: 32,
min_leaf_frac: 32,
change_counter: 1,
database_size: 1,
database_size: 0,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is true. The SQLite file always has the database header but more important the sqlite_schema table on page 1. @pereman2, @jussisaurio, please do correct me if i am wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah tests are failing and it seems to be because of that.

On an empty db page_count returns 0 on sqlite - I am investigating why

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, page 1 is allocated with db initialization and never deallocated. One of the reasons why balancing becomes a bit complicated.

freelist_trunk_page: 0,
freelist_pages: 0,
schema_cookie: 0,
Expand Down