Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove urdf from file names with macro definition #326

Open
wants to merge 1 commit into
base: humble
Choose a base branch
from

Conversation

galou
Copy link
Contributor

@galou galou commented Dec 12, 2023

Remove .urdf from file names of xacro files that only define macros.

Description

Rename .urdf.xacro to _macro.xacro.

Fixes #321.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Respect of conventions (breaking-change for people using xacro files that are maybe not part of the public API)

How Has This Been Tested?

Open in CROSS.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Remove `.urdf` from file names of xacro files that only define macros.

Signed-off-by: Gaël Écorchard <[email protected]>
@galou galou requested a review from hilary-luo as a code owner December 12, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

urdf.xacro should be reserved for files that generate a valid URDF description.
1 participant