Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add support for configurable ports in Docker Compose #46 #52

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

GJS2162
Copy link

@GJS2162 GJS2162 commented May 25, 2024

This pull request updates the Docker Compose configuration to support dynamic port configuration using environment variables. The changes include modifying the Docker Compose file to utilize environment variables for specifying ports, enhancing flexibility and customization options. Additionally, a Python script is provided to automate the modification process. Issue #46 tracks the implementation of this enhancement.

GJS2162 and others added 2 commits May 26, 2024 00:46
- Added a Python script named modify_compose.py to automate Docker Compose file modifications.
- The script utilizes the PyYAML library to parse and modify YAML data.
- Demonstrated how to use the script to modify a Docker Compose file, specifying a simple port mapping change.
@tushar5526
Copy link
Owner

Can you fix the pre-commit tests ?

@GJS2162
Copy link
Author

GJS2162 commented May 29, 2024

Can you fix the pre-commit tests ?

Sure, I’ll look into it. In the meantime, could you provide me with some additional information or resources that might help?

@Mr-Sunglasses
Copy link
Collaborator

Can you fix the pre-commit tests ?

Sure, I’ll look into it. In the meantime, could you provide me with some additional information or resources that might help?

Ref: https://pre-commit.com/#usage

@GJS2162
Copy link
Author

GJS2162 commented May 30, 2024

Can you fix the pre-commit tests ?

I removed the script which I have added, I think now it will work.
pre-commit job were running for this commit : 11ac865

@GJS2162
Copy link
Author

GJS2162 commented May 30, 2024

Can you fix the pre-commit tests ?

Sure, I’ll look into it. In the meantime, could you provide me with some additional information or resources that might help?

Ref: https://pre-commit.com/#usage

Thank you Kanishk for the resource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants