Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release build of Android #7299

Closed
charlag opened this issue Jul 29, 2024 · 2 comments · Fixed by #7300
Closed

Fix release build of Android #7299

charlag opened this issue Jul 29, 2024 · 2 comments · Fixed by #7300
Labels
state:tested We tested it and are about to release it
Milestone
240.240809+

Comments

@charlag
Copy link
Contributor

charlag commented Jul 29, 2024 •
edited
Loading

Android app fails to build because of the code shrinking that was applied to SDK code too aggressively.
charlag added a commit that referenced this issue Jul 29, 2024
@charlag
[android, sdk] Fix code shrinking rules
c30b7e9 
fix #7299
@charlag charlag mentioned this issue Jul 29, 2024
Merged
@charlag charlag linked a pull request Jul 29, 2024 that will close this issue
[android, sdk] Fix code shrinking rules #7300
Merged
@charlag charlag closed this as completed Jul 29, 2024
@charlag
Copy link
Contributor Author

charlag commented Jul 30, 2024

some methods were not found still

@charlag charlag reopened this Jul 30, 2024
charlag added a commit that referenced this issue Jul 30, 2024
@charlag
[android, sdk] Fix shrinking rules (again)
2b6b611 
The previous ruleset was insufficient as it didn't keep the class
members.

We decided to change the approach and not try to minify the library
artifact and instead let the application code do it with the help
of provided consumer-rules.pro.

This results in only actually used code being retained and simplifies
the configuration.

fix #7299
@charlag charlag mentioned this issue Jul 30, 2024
Merged
@paw-hub
Copy link
Contributor

paw-hub commented Jul 30, 2024

Closed via #7302

@paw-hub paw-hub closed this as completed Jul 30, 2024
rezbyte pushed a commit that referenced this issue Aug 2, 2024
@charlag @rezbyte
[android, sdk] Fix code shrinking rules
b16ce2f 
fix #7299
rezbyte pushed a commit that referenced this issue Aug 2, 2024
@charlag @rezbyte
[android, sdk] Fix code shrinking rules
043142b 
fix #7299
rezbyte pushed a commit that referenced this issue Aug 6, 2024
@charlag @rezbyte
[android, sdk] Fix code shrinking rules
b94accd 
fix #7299
@rezbyte rezbyte added this to the 240.240807.0 milestone Aug 7, 2024
murilopereirame pushed a commit that referenced this issue Aug 8, 2024
@charlag
[android, sdk] Fix code shrinking rules
9ff2079 
fix #7299
@paw-hub paw-hub added the state:tested We tested it and are about to release it label Aug 13, 2024
domesticated-raptor pushed a commit that referenced this issue Aug 15, 2024
@charlag @domesticated-raptor
[android, sdk] Fix code shrinking rules
1b2cab5 
fix #7299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state:tested We tested it and are about to release it
Projects
None yet
Milestone
240.240809+
Development

Successfully merging a pull request may close this issue.

[android, sdk] Fix code shrinking rules tutao/tutanota
3 participants
@charlag @rezbyte @paw-hub