[android, sdk] Fix shrinking rules (again) #7302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlag
force-pushed
the
sdk-android-shrinker-2
branch
from
2b6b611 to
a687811
Compare
|
I forgot one change sorry |
This is needed because test on Github might be running on slightly lower iOS version and it matches our general deployment target.
charlag
force-pushed
the
sdk-android-shrinker-2
branch
from
a687811 to
c7a3819
Compare
paw-hub
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous ruleset was insufficient as it didn't keep the class members.
We decided to change the approach and not try to minify the library artifact and instead let the application code do it with the help of provided consumer-rules.pro.
This results in only actually used code being retained and simplifies the configuration.
fix #7299