Fix double-clicking on a search category logging out the desktop client #7325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
rezbyte
force-pushed
the
dev-mail
branch
2 times, most recently
from
6b5f03c to
d8c32e0
Compare
rezbyte
force-pushed
the
7319-search-double-click-crash
branch
2 times, most recently
from
8fe0319 to
6a6d4b2
Compare
The chromium inside Electron reloads the page when navigating to '#'. This causes the desktop client to log out when clicking on a search category for the second time. To avoid this, we generate the current url. Closes #7319.
rezbyte
force-pushed
the
7319-search-double-click-crash
branch
from
6a6d4b2 to
b862fd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7319.
Closes #7184.