Fix invalid value attachments #7356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Rust models were out of sync with ts models. 2. JsonSerializer was not handling array of ListElementReference's correctly #7355
charlag
force-pushed
the
fix-invalid-value-attachments-7355
branch
from
a579e59 to
08d8363
Compare
wec43
reviewed
Aug 8, 2024
| } | ||
| ( | ||
| AssociationType::ListElementAssociation, | ||
| Cardinality::One, | ||
| Cardinality::One | Cardinality::ZeroOrOne, |
There was a problem hiding this comment.
For ListElementAssociation, ZeroOrOne is not Option?
There was a problem hiding this comment.
what do you mean? We already handle all ZeroOrOne + Null cases together?
There was a problem hiding this comment.
Ah ok I got confused. There are too many conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #7355