Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation list model #8351

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

paw-hub
Copy link
Contributor

@paw-hub paw-hub commented Jan 22, 2025

No description provided.

@paw-hub paw-hub force-pushed the 8223-conversation-list-model branch from 20ba81d to 72a61ad Compare January 23, 2025 17:41
@BijinDev BijinDev force-pushed the 8223-conversation-list-model branch from 1ded82d to 0367ecb Compare January 24, 2025 09:03
@BijinDev BijinDev force-pushed the 8223-conversation-list-model branch from 4d5eaf9 to a3c9c89 Compare January 27, 2025 08:24
@BijinDev BijinDev marked this pull request as ready for review January 27, 2025 08:26
@BijinDev BijinDev linked an issue Jan 27, 2025 that may be closed by this pull request
40 tasks
@BijinDev BijinDev force-pushed the 8223-conversation-list-model branch from a3c9c89 to 2e54f1d Compare January 28, 2025 13:41
Copy link
Contributor

@charlag charlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still didn't get everything but it's already a great effort!

src/mail-app/mail/model/ConversationListModel.ts Outdated Show resolved Hide resolved
src/mail-app/mail/model/ConversationListModel.ts Outdated Show resolved Hide resolved
src/mail-app/mail/model/ConversationListModel.ts Outdated Show resolved Hide resolved
src/mail-app/mail/model/ConversationListModel.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@charlag charlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk why my comments are pending sorry

src/mail-app/mail/model/MailSetListModel.ts Outdated Show resolved Hide resolved
src/mail-app/mail/model/ConversationListModel.ts Outdated Show resolved Hide resolved
@wrdhub
Copy link
Contributor

wrdhub commented Feb 3, 2025

Another thing I noticed: when you apply or remove a label this change is not shown in the mail list immediately. You have to reload to see it.

@paw-hub paw-hub force-pushed the 8223-conversation-list-model branch 2 times, most recently from 0175167 to fbb87ef Compare February 3, 2025 14:00
@paw-hub
Copy link
Contributor Author

paw-hub commented Feb 3, 2025

Another thing I noticed: when you apply or remove a label this change is not shown in the mail list immediately. You have to reload to see it.

This should now be fixed. Thanks for reporting this!

@paw-hub paw-hub force-pushed the 8223-conversation-list-model branch 4 times, most recently from 1c7ea72 to cd43326 Compare February 6, 2025 09:41
@paw-hub paw-hub force-pushed the 8223-conversation-list-model branch from cd43326 to f71566a Compare February 6, 2025 09:50
src/mail-app/mail/model/ConversationListModel.ts Outdated Show resolved Hide resolved
src/mail-app/mail/model/ConversationListModel.ts Outdated Show resolved Hide resolved
src/mail-app/mail/view/MailViewModel.ts Outdated Show resolved Hide resolved
src/mail-app/mail/view/MailViewModel.ts Outdated Show resolved Hide resolved
@charlag
Copy link
Contributor

charlag commented Feb 6, 2025

To not forget: switching between folders is slow

@paw-hub
Copy link
Contributor Author

paw-hub commented Feb 6, 2025

It seems to wait until redraw (if you move your cursor a bit after selecting the new folder, it will switch). I wonder how this got borked?

@charlag charlag force-pushed the 8223-conversation-list-model branch from 2ee60b2 to dfb4d04 Compare February 6, 2025 15:10
paw-hub and others added 2 commits February 6, 2025 17:18
- This list model groups all emails by conversation in the mail list
- Also adds setting for grouping by conversation (i.e. enables this)
- The setting is overridden for SENT and DRAFT folder types (it uses the
  other per-mail list model instead)
- Adds MailSetListModel which provides a common interface for the
  MailViewModel so that additional list models can be created; it is
  used for MailListModel and the new ConversationListModel, but it can
  be extended to even more list models in the future if it is ever
  desired.

Note: This does not include actions. Any action you do (delete, archive,
etc.) will be applied to the selected email. The purpose of this commit
is to just implement the list model. See #5051 for more information.

Closes #8223

Co-authored-by: bir <[email protected]>
Co-authored-by: ivk <[email protected]>
@charlag charlag force-pushed the 8223-conversation-list-model branch from 980e994 to c0d7723 Compare February 6, 2025 16:18
@charlag charlag changed the base branch from dev-mail to conversation-integration February 6, 2025 16:19
@charlag charlag merged commit c0d7723 into conversation-integration Feb 6, 2025
12 checks passed
@charlag charlag deleted the 8223-conversation-list-model branch February 6, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversation-based list model
4 participants