replace pqcrypto-kyber with pqcrypto-mlkem and update dependencies #8424
+145
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add required sha3/keccak dependency to turn ml-kem into kyber we turn ml-kem into kyber for backwards compatibility with TutaCrypt #tutadb1950
charlag
reviewed
Jan 30, 2025
| fn from(value: PQCryptoKyber1024PublicKey) -> Self { | ||
| /// This is a redundant step to bind the derived shared secret to the ciphertext. | ||
| /// It was part of the original round 3 Kyber submission specification and the reference implementation. | ||
| /// It was removed from the NIST ML-KEM draft for efficiency because the re-encryption step in decapsulation prevents any attacks. |
There was a problem hiding this comment.
I think a word is missing in this sentence :)
There was a problem hiding this comment.
I tried making it clearer. not sure which word is missing. is it ok now?
charlag
reviewed
Jan 30, 2025
| unbound_shared_secret.as_bytes(), | ||
| hashed_ciphertext.as_slice(), | ||
| ] | ||
| .concat(); |
There was a problem hiding this comment.
we could avoid concating them if we provide both to the hasher one after another. Not sure if it's worth it though (we can make a macro :D)
There was a problem hiding this comment.
I pushed a commit to address this. what do you think?
…kem to kyber hack
…em to kyber ciphertext binding
vaf-hub
force-pushed
the
crypto/update-pqcrypto-library-1950
branch
from
53547fb to
4902b4f
Compare
charlag
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add required sha3/keccak dependency to turn ml-kem into kyber we turn ml-kem into kyber for backwards compatibility with TutaCrypt
#tutadb1950