Dev infra #8438
Open
Dev infra #8438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuta-sudipg
force-pushed
the
dev-infra
branch
3 times, most recently
from
9011447 to
5abab26
Compare
ganthern
force-pushed
the
dev-infra
branch
2 times, most recently
from
a90f301 to
926eb4f
Compare
ganthern
reviewed
Jan 30, 2025
| "uniffi-bindgen", | ||
| "generate", | ||
| "--library", | ||
| "${layout.buildDirectory.asFile.get()}/rustJniLibs/android/${dir}/libtutasdk.so", |
There was a problem hiding this comment.
these paths are still wrong, probably because of the changed target directory. https://github.com/tutao/tutanota/actions/runs/13056825592 will probably fail because of that
Co-authored-by: jhm <[email protected]>
the progress estimation for failed imports was not stopped. this gave the impression that the import was still ongoing. we now reset the state if an error happens during import preparation and will pause the running import if an async error happens. this will allow the user to try to resume it and see the snackbar or notification if the error happens again. also adds some local state cleanup if the import fails before being set up on the server
previously, we didn't increment the counter for all failure cases, leading to the finished import showing 0 failed mails even though some actually failed. we still leave some edge cases where we fail to import a mail but also fail to mark it as failed.
- do not depend on un-needed tokio features - move rand to Cargo.toml - use latest uniffi-bindgen from crates.io
commands like `cargo test`, `cargo clippy` or `cargo check` now require the `--all` or `--package` flags to choose which workspace members they should run for. this prevents the mobile apps from building node-mimimi
mlock is used by sqlcipher but is not allowed on our test containers see sqlcipher/sqlcipher-android#48 (comment) see systemd/systemd#9414 (comment)
ganthern
force-pushed
the
dev-infra
branch
2 times, most recently
from
0e6871b to
e39bf8b
Compare
- build tutasdk object file in generateBinding task note: not tested on ci/jenkins
tuta-sudipg
force-pushed
the
dev-infra
branch
6 times, most recently
from
99a1d2e to
b8d442a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.