[desktop] De-init node-mimimi logger on quit instead of on before-quit #8641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds TutanotaModelV84 Close #8373 Co-authored-by: Willow <[email protected]> Co-authored-by: bir <[email protected]>
Re-implement downloading of mails during search indexing: - download mail details instead of mails from mail bags to ensure correctness of date range - always download MailSetEntry's in full chunks to avoid cache-related issues Close #8564 Co-authored-by: bir <[email protected]> Co-authored-by: wrd <[email protected]>
Using direct array accesses makes the code harder to understand. Change it to use listIdPart/elementIdPart so the intention is clearer.
Instead of indexing day-by-day, we can process after we've reached some threshold. We should still iterate by day, but we should index multiple days at once. This reduces the number of requests by over 80% on some mailboxes, and it may cut loading time in half in such cases. Closes #8599 Co-authored-by: bir <[email protected]>
before-quit might be emitted multiple times such as on an update. This causes the logger to panic due to being de-inited twice. Close #8619 Co-authored-by: paw <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before-quit might be emitted multiple times such as on an update. This causes the logger to panic due to being de-inited twice.
Close #8619