Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQ Changes for Streamlit #642

Merged
merged 2 commits into from
Nov 1, 2024
Merged

DQ Changes for Streamlit #642

merged 2 commits into from
Nov 1, 2024

Conversation

thutuva
Copy link
Member

@thutuva thutuva commented Oct 31, 2024

Describe your changes

Please include a summary of any changes.

  • added zeros on some column to replace NULL to make the display look better in streamlit
  • rearranged some columns to make it easier to understand the data

How has this been tested?

Please describe the tests you ran to verify your changes. Provide instructions or code to reproduce output.
CI

Reviewer focus

Please summarize the specific items you’d like the reviewer(s) to look into.

Checklist before requesting a review

  • I have added at least one Github label to this PR (bug, enhancement, breaking change,...)
  • My code follows style guidelines
  • (New models) YAML files are categorized by sub folder and models listed in alphabetical order
  • (New models) I have added a config to each new model to enable it for claims and/or clinical data
  • (New models) I have added the variable tuva_last_run to the final output
  • (Optional) I have recorded a Loom to explain this PR

Package release checklist

  • I have updated dbt docs
  • I have updated the version number in the dbt_project.yml

(Optional) Gif of how this PR makes you feel

Loom link

@thutuva thutuva changed the title added zeros; rearranged some columns DQ Changes for Streamlit Oct 31, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you switch this to false please?

@tom-tuva tom-tuva merged commit d9ec783 into main Nov 1, 2024
8 checks passed
@tom-tuva tom-tuva deleted the dq_streamlit_edits branch November 1, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants