fix: Checks all cues for variants and uses constant for magic string

tv2 · Jun 14, 2024 · 26f3ceb · 26f3ceb
1 parent 28560cc
commit 26f3ceb
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/tv2-common/getSegment.ts b/src/tv2-common/getSegment.ts
@@ -97,6 +97,8 @@ interface SegmentMetadata {
 	miniShelfVideoClipFile?: string
 }
 
+const SHOW_STYLE_VARIANT_LOWER_CASE_CUE: string = 'sofie=showstylevariant'
+
 export async function getSegmentBase<ShowStyleConfig extends TV2ShowStyleConfig>(
 	context: SegmentContext<ShowStyleConfig>,
 	ingestSegment: IngestSegment,
@@ -127,7 +129,7 @@ export async function getSegmentBase<ShowStyleConfig extends TV2ShowStyleConfig>
 	}
 
 	segment.definesShowStyleVariant = iNewsStory.cues.some((cue) =>
-		cue ? cue[0].toLowerCase().includes('showstylevariant') : false
+		cue?.some((cueElement) => cueElement.toLowerCase().includes(SHOW_STYLE_VARIANT_LOWER_CASE_CUE))
 	)
 
 	const totalTimeMs = TimeFromINewsField(iNewsStory.fields.totalTime) * 1000