SOF-1539 No longer uses 'while x' for server Parts and Pieces. #218
+4
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey have a simple 'start=0'
LindvedKrvang
requested review from
KvelaGorrrrnio,
andr9528 and
RasmusAlbrektsen
RasmusAlbrektsen
approved these changes
Sep 19, 2023
KvelaGorrrrnio
approved these changes
Sep 19, 2023
andr9528
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fit the new way of building the Timeline it has been necessary to change the TimelineEnable of Servers.
Instead of using a "while some class" they now just start at 0.
Also removed a TimelineObject which was supposed to ensure the Servers wasn't playing when it isn't on Air. Removing it seems to have had zero effect, so hence it is gone.
Funnily enough, this change still works with old Core.