SOF-1824 Add 1/2 audio track to ingested EVS #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LindvedKrvang
requested review from
KvelaGorrrrnio,
RasmusAlbrektsen,
k-primeholding-dim and
vivanov90
k-primeholding-dim
approved these changes
Mar 13, 2024
vivanov90
reviewed
Mar 14, 2024
| @@ -675,7 +675,7 @@ export function getSourceDefinition(typeStr: string): SourceDefinition | undefin | |||
| } | |||
| } else if (EVS_RED_TEXT.test(typeStr)) { | |||
| const strippedToken = typeStr.match(EVS_RED_TEXT) | |||
| const id = `EVS ${strippedToken![1].toUpperCase()}` | |||
| const id = `EVS ${strippedToken![1].toUpperCase()} 1/2` | |||
There was a problem hiding this comment.
This will find the correct configuration, but will give the incorrect piece name. When EVS 1 is written in iNews, the corresponding piece name should be EVS 1 as well. It is only action pieces that should show the audio track suffix.
There was a problem hiding this comment.
Good catch.
I have updated it so the name does not get the audio track (the 1/2).
KvelaGorrrrnio
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the changes to have an "audio track" on the EVS in #231, the ingested EVS from iNews could no longer find the correct sourceLayer.
This is solved by adding
1/2to the EVS id.