SOF-2203: Uses part index in segment to assign action rank. #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KvelaGorrrrnio
requested review from
MadsThy,
LindvedKrvang,
RasmusAlbrektsen and
nicolelefevre99
LindvedKrvang
approved these changes
Sep 11, 2024
RasmusAlbrektsen
approved these changes
Sep 11, 2024
KvelaGorrrrnio
deleted the
SOF-2203/assign-action-rank-properly-by-segment-part-and-cue-order
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, action ranks were calculated by segment rank and cue index in part. This caused actions generated from segments, with multiple parts to not have the right order and get mixed if more than one action is generated per part.