Division: use twbs/rfs for backward & forward compatibility #1229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to @stof's suggestion at #1226 (comment). Adopts the https://github.com/twbs/rfs library to handle division in a forward- and backward- compatible fashion in both libsass and dart-sass. Reverts
devDependency
pin tonode-sass
.I am not convinced that merging this in favor of
math.div()
is the best choice, but since it is a marginally viable proposal, I felt like I should put the option up for consideration. This suggestion follows in the footsteps of Bootstrap 4 and 5, but I do want to note that more serious breaking change around@import
are scheduled for October, and we will have to make a clean break with libsass by then in any case — either with a "3.5" release, or with a fork.See also
#1217
#1219
#1221