Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Division: use twbs/rfs for backward & forward compatibility #1229

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AprilArcus
Copy link
Contributor

@AprilArcus AprilArcus commented Mar 2, 2022

Follow-up to @stof's suggestion at #1226 (comment). Adopts the https://github.com/twbs/rfs library to handle division in a forward- and backward- compatible fashion in both libsass and dart-sass. Reverts devDependency pin to node-sass.

I am not convinced that merging this in favor of math.div() is the best choice, but since it is a marginally viable proposal, I felt like I should put the option up for consideration. This suggestion follows in the footsteps of Bootstrap 4 and 5, but I do want to note that more serious breaking change around @import are scheduled for October, and we will have to make a clean break with libsass by then in any case — either with a "3.5" release, or with a fork.

See also

#1217
#1219
#1221

@stof
Copy link

stof commented Mar 18, 2022

Why importing the whole RFS library (which is about responsive font sizes) instead of only the divide function ?

@AprilArcus
Copy link
Contributor Author

AprilArcus commented Mar 25, 2022

I just tried to do the Bootstrap 4-est thing. In truth I don't intend to maintain this branch or push for merging it, but I did want to evaluate the feasibility of an alternative to Math.div that you suggested. Feel free to take this and run with it; as for the rest it's up to the maintainers.

@stof
Copy link

stof commented Mar 25, 2022

@AprilArcus the math.div replacement in Bootstrap 4 is just the divide function, not the whole RFS library (which is about a specific feature, that happens to need doing divisions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants