Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: clipboard icon not showing after multiple press #40917

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MohamadSalman11
Copy link
Contributor

@MohamadSalman11 MohamadSalman11 commented Oct 7, 2024

Description

The clipboard icon is not showing anymore when the user clicks on the tick after it has been copied. This approach can also be applied in other repositories like the blog. For more details, you can check out the linked issue.

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@MohamadSalman11 MohamadSalman11 requested a review from a team as a code owner October 7, 2024 20:25
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said in #40915 (comment), I think it's probably not worth spending too much time trying to find an alternative approach, as this is an edge case only in the documentation. Tested on several browsers and seems to work pretty well.

LGTM! I'll let @twbs/js-review other members give their feedback.

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax could be compacted but it works perfectly to me, let's ship it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The clipboard icon is not shown anymore when the tick icon is clicked
3 participants