Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the 'Extra space on GroupBy option menu' #11179

Merged
merged 4 commits into from
Mar 26, 2025

Conversation

MahdadGhasemian
Copy link
Contributor

#10969

Fixed!

image

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed extra spacing in the GroupBy option menu by modifying the component structure in the kanban view dropdown.

  • Changed React fragment to <div> wrapper in /packages/twenty-front/src/modules/object-record/object-options-dropdown/components/ObjectOptionsDropdownRecordGroupsContent.tsx to eliminate unwanted bottom spacing
  • Reordered imports for better code organization

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@@ -149,7 +149,7 @@ export const ObjectOptionsDropdownRecordGroupsContent = () => {
text={`Hidden ${recordGroupFieldMetadata?.label ?? ''}`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider adding a translation wrapper around this string for i18n consistency

Suggested change
text={`Hidden ${recordGroupFieldMetadata?.label ?? ''}`}
text={t`Hidden ${recordGroupFieldMetadata?.label ?? ''}`}

@charlesBochet charlesBochet merged commit 2cc5992 into twentyhq:main Mar 26, 2025
3 checks passed
@charlesBochet
Copy link
Member

Thanks @MahdadGhasemian for the PR
as mentioned in the issue, using scrollable=false fixes the problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants