Fix filter multi select #8682
Merged
Fix filter multi select #8682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors the filter dropdown functionality to implement a nested dropdown pattern for operand selection, improving UI by allowing operands to appear over the main selection with proper offset spacing.
- Added new
ObjectFilterDropdownOperandDropdowncomponent in/packages/twenty-front/src/modules/object-record/object-filter-dropdown/components/ObjectFilterDropdownOperandDropdown.tsxto handle nested dropdown behavior - Added
DropdownUnmountEffectcomponent in/packages/twenty-front/src/modules/ui/layout/dropdown/components/DropdownUnmountEffect.tsxto properly close dropdowns on component unmount - Added
ObjectFilterDropdownOperandDropdownscope toFiltersHotkeyScopeenum for keyboard shortcut handling - Removed old unfolding state logic (
isObjectFilterDropdownOperandSelectUnfolded) across multiple components in favor of nested dropdown approach - Added
classNameprop support toDropdownMenuHeaderandDropdownMenuItemsContainerfor better style customization
18 file(s) reviewed, 8 comment(s)
Edit PR Review Bot Settings | Greptile
...ules/object-record/object-filter-dropdown/components/ObjectFilterDropdownOperandDropdown.tsx
Show resolved
Hide resolved
...ules/object-record/object-filter-dropdown/components/ObjectFilterDropdownOperandDropdown.tsx
Show resolved
Hide resolved
...ules/object-record/object-filter-dropdown/components/ObjectFilterDropdownOperandDropdown.tsx
Outdated
Show resolved
Hide resolved
...ules/object-record/object-filter-dropdown/components/ObjectFilterDropdownOperandDropdown.tsx
Show resolved
Hide resolved
...odules/object-record/object-filter-dropdown/components/ObjectFilterDropdownOperandSelect.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/dropdown/components/Dropdown.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/dropdown/components/DropdownMenuHeader.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/dropdown/components/DropdownMenuHeader.tsx
Show resolved
Hide resolved
martmull
approved these changes
Nov 22, 2024
...ules/object-record/object-filter-dropdown/components/ObjectFilterDropdownOperandDropdown.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObjectFilterDropdownOperandDropdownso the operand can be opened over the selection with an offsetDropdownUnmountEffectto close the dropdown when the component unmountsBefore:
After:
